Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top imports #174

Merged
merged 3 commits into from
Apr 25, 2020
Merged

Top imports #174

merged 3 commits into from
Apr 25, 2020

Conversation

felix-hilden
Copy link
Owner

@felix-hilden felix-hilden commented Apr 16, 2020

Let's provide top level imports already before we get to version 2.

Some things to do:

  • Change the documentation to use the new imports
  • Add a notice of the upcoming change
  • If possible, establish a proper deprecation

@felix-hilden
Copy link
Owner Author

I think properly deprecating (warning users) is not possible to do consistently. We would need to change where everything is defined, and then import them back to the original locations. Then top level imports would be done from the new places and if the original locations are imported, a warning would be issued. But we still need to provide a way to set options. So I think a notice will be enough. Along with changing all the documentation, users will likely naturally gravitate towards the new style of imports.

@felix-hilden
Copy link
Owner Author

And just to have the links: this also addresses issues #81 and #154 by adding the top imports. Neither is closed, because work is left to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant