fix: remove allowCompletedRetries from public option interface

felixmosh · Jan 3, 2023 · c96658f · c96658f
1 parent 139fcd4
commit c96658f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/packages/api/src/queueAdapters/base.ts b/packages/api/src/queueAdapters/base.ts
@@ -15,7 +15,9 @@ export abstract class BaseAdapter {
   public readonly description: string;
   private formatters = new Map<FormatterField, (data: any) => any>();
 
-  protected constructor(options: Partial<QueueAdapterOptions> = {}) {
+  protected constructor(
+    options: Partial<QueueAdapterOptions & { allowCompletedRetries: boolean }> = {}
+  ) {
     this.readOnlyMode = options.readOnlyMode === true;
     this.allowRetries = this.readOnlyMode ? false : options.allowRetries !== false;
     this.allowCompletedRetries = this.allowRetries && options.allowCompletedRetries !== false;

diff --git a/packages/api/src/queueAdapters/bull.ts b/packages/api/src/queueAdapters/bull.ts
@@ -4,8 +4,7 @@ import { BaseAdapter } from './base';
 
 export class BullAdapter extends BaseAdapter {
   constructor(public queue: Queue, options: Partial<QueueAdapterOptions> = {}) {
-    options.allowCompletedRetries = false; // bull doesn't support this
-    super(options);
+    super({ ...options, allowCompletedRetries: false });
   }
 
   public getRedisInfo(): Promise<string> {
@@ -66,5 +65,3 @@ export class BullAdapter extends BaseAdapter {
     return this.queue.empty();
   }
 }
-
-
diff --git a/packages/api/typings/app.ts b/packages/api/typings/app.ts
@@ -15,7 +15,6 @@ export type JobCounts = Record<Status, number>;
 export interface QueueAdapterOptions {
   readOnlyMode: boolean;
   allowRetries: boolean;
-  allowCompletedRetries: boolean;
   prefix: string;
   description: string;
 }