Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing scrolling behavior #477

Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix: add missing scrolling behavior #477

merged 2 commits into from
Oct 25, 2022

Conversation

camiaei
Copy link
Contributor

@camiaei camiaei commented Oct 22, 2022

hi there👋

This PR adds vertical scrolling but hides the generated scrollbar.

bull-dashboard-scroll-y.mp4

@felixmosh
Copy link
Owner

Hi, thank you for this PR.
It is problematic to hide the scroller all together.
You need to indicate the user that there is more to scroll.

@camiaei
Copy link
Contributor Author

camiaei commented Oct 22, 2022

You're right. I saw that in another place you use a thinner scrollbar:

bull-board-scroll-y-thin.mp4

@jaroslaw-weber jaroslaw-weber mentioned this pull request Oct 25, 2022
Closed
@felixmosh felixmosh merged commit 77226d5 into felixmosh:master Oct 25, 2022
@felixmosh
Copy link
Owner

Thank you for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camiaei @felixmosh