Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NestJS] Global prefix support #592

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

DennisSnijder
Copy link
Contributor

Context

See #591

What has been done

  • Checked for the existence of a global prefix in the ApplicationConfig from NestJS

@DennisSnijder
Copy link
Contributor Author

@felixmosh ready for review 😋

@felixmosh
Copy link
Owner

closes #591

@felixmosh
Copy link
Owner

closes #591

@felixmosh felixmosh merged commit aec2276 into felixmosh:master Jun 23, 2023
@felixmosh
Copy link
Owner

Thank you @DennisSnijder & @SimonRosenau 🙏🏼
Released in v5.5.2

@piotr-skowronski-prpl
Copy link

piotr-skowronski-prpl commented Jul 10, 2023

@DennisSnijder It looks like there's still a bug here.
When setting the global prefix without the / at the beginning, like so app.setGlobalPrefix('api');, assets are taken from /api/api/queues which doesn't exist, so it fails.
And the official NestJS documentation does not use the leading / in the global prefix section so people will be tripping over this.

@DennisSnijder
Copy link
Contributor Author

@DennisSnijder It looks like there's still a bug here. When setting the global prefix without the / at the beginning, like so app.setGlobalPrefix('api');, assets are taken from /api/api/queues which doesn't exist, so it fails. And the official NestJS documentation does not use the leading / in the global prefix section so people will be tripping over this.

Good catch! i'll take a look into it later today!

dimbslmh added a commit to dimbslmh/bull-board that referenced this pull request Mar 21, 2024
dimbslmh added a commit to dimbslmh/bull-board that referenced this pull request Mar 21, 2024
dimbslmh added a commit to dimbslmh/bull-board that referenced this pull request Mar 21, 2024
This was referenced Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants