Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prioritized #622

Closed
wants to merge 1 commit into from
Closed

Conversation

carlosbaraza
Copy link

  • Support prioritized status
  • Allow cleaning waiting and prioritized, no reason why we shouldn't be able to do this.

Closes #608

@carlosbaraza
Copy link
Author

@felixmosh let me know if there is anything to address.

@felixmosh
Copy link
Owner

Hi @carlosbaraza thank you for this PR 🙏🏼

How does this change affects bull (bullMQ) based boards?

@carlosbaraza
Copy link
Author

Not sure I understand the question. You mean bull vs bullmq? Not sure. How could we test that?

@felixmosh
Copy link
Owner

run example.ts file

@felixmosh
Copy link
Owner

felixmosh commented Aug 24, 2023

Bull doesn't have this new status, therefore, it should not be displayed in the menu.
I think that it is better that each QAdapter will return all supported statuses, WDYT?

@Klemah
Copy link

Klemah commented Aug 29, 2023

Looking forward to having this merged, currently prioritized jobs get completely hidden and are impossible to manage on my end. Thanks!

@felixmosh
Copy link
Owner

@carlosbaraza any update regarding my questions?

@carlosbaraza
Copy link
Author

Sorry guys, I have a lot of things on my plate and I can not spend more time on this right now. @felixmosh @Klemah if you know what needs to be done, please go ahead and modify the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Prioritized Jobs
3 participants