Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nestjs): edit bullboard path have global prefix when using fastify #639

Conversation

lytaitruong
Copy link

Hi @felixmosh, first of all thank you and everyone build this repo. It nice

  • I using NestJS + Fastify, and now try implement the BullMQ, so I add your library, it nice!

  • But when I test it not recognize if I have a global prefix in Fastify
    Issue

  • I've read all the issues of this repo but not find the best way to fix this

  • So I try on your code and figure out the issue in here
    Bug

The result after change my code is working correctly my expectation
Fixway

I create this PR maybe it make it right. If you think not more problem you can merge it

Thank and have a good day

@felixmosh
Copy link
Owner

felixmosh commented Oct 19, 2023

Hi @lytaitruong thank you for this PR 🙏🏼

Unfortunately I'm not familiar with Nest.js, so I'm not sure if this solves the problem, maybe @DennisSnijder can review this PR?

@DennisSnijder
Copy link
Contributor

Hi @lytaitruong thank you for this!

I've been debugging / trying to get the prefix working with Fastify for quite some time now, previously it was due to a prefixing bug in NesJS with the Fastify adapter I wasn't able to get it to work.

I'll try out the PR in the next few days!

Thank you!

@h4sohail
Copy link

h4sohail commented Jan 2, 2024

Can we merge this in? I'm having a similar issue with using global prefixes.

@felixmosh
Copy link
Owner

Can we merge this in? I'm having a similar issue with using global prefixes.

Looks like it is an issue with Nest.js FastifyAdapter, threfore, I don't think it should be solved in this lib.

@anteqkois
Copy link

@felixmosh Any progress? It also don't work for me when I use global prefix

@anteqkois
Copy link

anteqkois commented Mar 9, 2024

@felixmosh I checked this PR and it fix the issue for NestJS with Fastify, but we can not use it in production or we must fork it and change one line only for this.

This was referenced Mar 21, 2024
@felixmosh
Copy link
Owner

closed by #704

@felixmosh felixmosh closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants