Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compactMode: add collapsible functionality + reog job card layout #687

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

ivnnv
Copy link
Contributor

@ivnnv ivnnv commented Feb 16, 2024

compact.mov

@ivnnv ivnnv mentioned this pull request Feb 16, 2024
packages/ui/package.json Outdated Show resolved Hide resolved
packages/ui/src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/JobCard/JobCard.tsx Outdated Show resolved Hide resolved
@ivnnv ivnnv requested a review from felixmosh February 18, 2024 16:46
@ivnnv
Copy link
Contributor Author

ivnnv commented Feb 23, 2024

hey @felixmosh did you have the chance to look at this updated and comments? I really want to contribute to the main repo (have many other improvements in mind) but otherwise Id need to just fork.

@felixmosh
Copy link
Owner

Hi, sorry I didn't managed to check it out yet, will do soon.
(I didn't forget about it)

Copy link
Owner

@felixmosh felixmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the PR looks Ok to me.
Thank you.

(FYI, After this PR will be merged I will change a bit styles)

}
}
}
export const Highlight: React.FC<HighlightProps> = ({ language, text }) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls move this refactor to a separate PR 🙏🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! lets process this first 👍🏽

@felixmosh felixmosh marked this pull request as ready for review February 25, 2024 10:20
@felixmosh felixmosh merged commit f3b3c2c into felixmosh:master Feb 27, 2024
4 checks passed
@felixmosh
Copy link
Owner

Thank you for this awsome PR.
I will publish it after I refactor some styles.

@felixmosh
Copy link
Owner

felixmosh commented Feb 27, 2024

closes #686

felixmosh added a commit that referenced this pull request Feb 27, 2024
@felixmosh
Copy link
Owner

felixmosh commented Feb 27, 2024

I probably needed to check the PR locally...
there is button inside a button...
image

And the collapse expand doesn't work for me...
I want to fix other bug, therefore, I will revert this PR... and will work on it later

@ivnnv can you open a new PR with the fixes for 2 issues I've mentioned?

felixmosh added a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants