fixpatch: projectm 3.1.12 #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryolitia
force-pushed
the
projectm
branch
2 times, most recently
from
5db76d4
to
cc43138
Compare
This commit should fix `dpf-plugins` building fault: https://archriscv.felixc.at/.status/log.htm?url=logs/dpf-plugins/dpf-plugins-1.7-2.log , although `projectm` itself can be built successfully with current riscv64 patch. The current patch uses `autoreconf` to update the outdated `config.{guess,sub}` , while also updating `libtool` at the same time, which breaking the behavior of `sed -i -e 's/ -shared / -Wl,-O1,--as-needed\0/g' libtool` in the original PKGBUILD, which causes projectm to be overlinked, more specifically linking `libprojectm.so` to `libqt5gui.so` and `libqt5opengl.so`, meanwhile `projectm`'s depends not containing `qt5-base`. Although, the `dpf-plugins` doesn't depend on `qt5-base` but `projectm`, then, boom. We believe in that just update the `config.{guess, sub}` is enough to build it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix
dpf-pluginsbuilding fault: https://archriscv.felixc.at/.status/log.htm?url=logs/dpf-plugins/dpf-plugins-1.7-2.log , althoughprojectmitself can be built successfully with current riscv64 patch.The current patch uses
autoreconfto update the outdatedconfig.{guess,sub}, while also updatinglibtoolat the same time, which breaking the behavior ofsed -i -e 's/ -shared / -Wl,-O1,--as-needed\0/g' libtoolin the original PKGBUILD, which causes projectm to be overlinked, more specifically linkinglibprojectm.sotolibqt5gui.soandlibqt5opengl.so, meanwhileprojectm's depends not containingqt5-base.Although, the
dpf-pluginsdoesn't depend onqt5-basebutprojectm, then, boom.We believe in that just update the
config.{guess,sub}is enough to build it.