Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConPTY support #128

Closed
7 of 8 tasks
felixse opened this issue Nov 13, 2018 · 7 comments
Closed
7 of 8 tasks

ConPTY support #128

felixse opened this issue Nov 13, 2018 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@felixse
Copy link
Owner

felixse commented Nov 13, 2018

So 1809 is about to be rereleased and its time to work on some ConPTY awesomeness.
I created a branch Dev/ConPty where I started integrating it. Its based on @pingzing's ModernPseudoSh (many kudos).

Todo:

  • Basic functionality
  • Resize
  • Handle shell exit
  • pass startup directory
  • hide backing console window
  • detect conPTY availability and fallback to winPTY if necessary
  • Communicate used pty to xterm.js so that we can enable the winPtyCompat addon if necessary
  • Investigate if we can add an option to start the shell process with admin rights

So if someone feels like playing around with ConPTY feel free to grab a task 😄

@felixse felixse added this to the 0.2.2.0 milestone Nov 13, 2018
@felixse felixse added the enhancement New feature or request label Nov 13, 2018
@felixse
Copy link
Owner Author

felixse commented Nov 19, 2018

image
Don't ask me whats going on with color 243

@hanskokx
Copy link
Contributor

hanskokx commented Nov 19, 2018 via email

@felixse felixse modified the milestones: 0.3.0.0, 0.4.0.0 Jan 2, 2019
@giggio
Copy link

giggio commented Jan 3, 2019

Awesome. Can't wait to use it. It is supposed to be a big step forward.

@parkovski
Copy link

Investigate if we can add an option to start the shell process with admin rights

I don't think you can do this easily. The most straightforward way is to use UAC to start an elevated broker process, as per this issue. To get an elevated child process requires tricks like I've been experimenting with here. I've researched this a lot, and I'm always happy to discuss it or explore other options.

@david50407
Copy link

After enabling conPTY, I cannot pass Ctrl-A (or Ctrl-<somekey>) into the terminal (it is working with always use winpty chekced), that is, I cannot use key-binding with screen or other cli tools.

conPTY also caused scrolling text away in terminal when I changed the window of screen.

@DRSDavidSoft
Copy link
Contributor

Awesome! 👍 Is it possible to include both ConPTY and WinPTY support in the project, and chose to load either at runtime?


Two off-topic questions, what color scheme and what kind of bash shell are you using in the screenshot? (WSL, Cygwin, MinGW or something else?)

@felixse
Copy link
Owner Author

felixse commented Mar 8, 2019

Awesome! 👍 Is it possible to include both ConPTY and WinPTY support in the project, and chose to load either at runtime?

Yes, the next version will have a configuration to switch between both (winpty by default, conpty is not quite ready yet).

Two off-topic questions, what color scheme and what kind of bash shell are you using in the screenshot? (WSL, Cygwin, MinGW or something else?)

Thats' just an unaltered unbuntu 18.04 bash and my configuration

@felixse felixse closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants