Web browser like tabs #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixse
reviewed
Jul 31, 2019
| @@ -95,5 +97,44 @@ private void UpdateLayoutMetrics() | |||
| PropertyChanged(this, new PropertyChangedEventArgs(nameof(CoreTitleBarPadding))); | |||
| } | |||
| } | |||
|
|
|||
| private void TabView_TabDraggedOutside(object sender, Microsoft.Toolkit.Uwp.UI.Controls.TabDraggedOutsideEventArgs e) | |||
There was a problem hiding this comment.
yes, sorry, good catch!
TabView worked pretty well except that it doesn't provide a template to customize whole tab header area for specific state (hovered, pressed, etc) and option to display tabs headers at the bottom of page. To have that desired customization it seems it's needed to redefine too much functionality of TabView's high level templates.
|
Awesome 👍 |
maxhora
added a commit
to maxhora/FluentTerminal
that referenced
this pull request
Jul 31, 2019
* Web browser like tabs. * Turn on AlwaysShowTabs by default. * removed unused event handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/jumptrading/FluentTerminal/issues/109
Known issue to be addressed in next step:
Not whole state of xterm.js is restored on drop of tab for restored buffer content (but new received terminal session is displaying fine).