Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retainExif option to retain Exif #159

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

zcf0508
Copy link
Contributor

@zcf0508 zcf0508 commented Aug 30, 2022

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

By default, the Exif information will be lost in the compressed image. If you want to keep the Exif information of the original image you can set the retainExif option to true

@zcf0508
Copy link
Contributor Author

zcf0508 commented Aug 30, 2022

@zcf0508 zcf0508 mentioned this pull request Sep 3, 2022
@fengyuanchen
Copy link
Owner

Is it necessary to add this feature? This is a question that requires careful consideration.

In fact, you can read Exif metadata on the browser side and upload it to the server side as a parameter along with the compressed image.

@zcf0508
Copy link
Contributor Author

zcf0508 commented Sep 4, 2022

@fengyuanchen
Thanks for the reply. In my case, I use this lib to build a browser-side image compress website, I hope that the users can choose whether or not to retain the Exif when they save the compressed image.

@patilanz
Copy link

patilanz commented Sep 5, 2022

Hey this feature will be very helpful. It can save a lot of time.

@lorenzomorandini
Copy link

@fengyuanchen I would like to ask for this feature to be merged too.
Having the image and the metadata divided adds a few challenges, first of all keeping them linked and consistent.

@RokuDagy
Copy link

Indeed, it would be useful to at least have the option to chose since it doesn't impact the code to much

@Robert-Lebedeu
Copy link

I was looking for this feature and I would love to see this merged.
If the purpose of this library is to compress images client-side, I don't see why you shouldn't have an option to keep the metadata.

@lorenzomorandini
Copy link

News on this?

@rgbskills
Copy link

Any updates?

@fengyuanchen fengyuanchen merged commit 8fe7582 into fengyuanchen:main Feb 12, 2023
@mjau-mjau
Copy link

Just a related comment. It would be amazing if this option (or similar option) could also retain IPTC data (caption, copyright, keywords etc). I believe the goal is to be able to compress images, while keeping ALL image meta data, as this is largely beneficial for image galleries etc when uploading and compressing images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants