Fix the TS types for the drag mode, smoothing quality and view mode options #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions The enums don't exist at runtime (as the source code does not have them). So declaring them as enum causes issues. String enums are replaced with a union of literal types. The ViewMode is turned into a const enum so that typescript will inline the numbers during compilation.
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 72.65% 72.65%
=======================================
Files 9 9
Lines 1532 1532
=======================================
Hits 1113 1113
Misses 419 419Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
Other information:
The enums don't exist at runtime (as the source code does not have them as it is not TS). So declaring them as enum causes issues. I got tsc warnings when trying to run it to check the JS code. Passing
moveexplicitly was not considered as a valid value for thedragoption.String enums are replaced with a union of literal types. The ViewMode is turned into a const enum so that typescript will inline the numbers during compilation instead of trying to access them on an object.
The switch from enum to a union of literals should be checked by TS users to see whether it breaks BC (but I think it was not working at all before).