Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natively get environment config to remove ember-get-config dependency #299

Merged
merged 6 commits into from
Mar 9, 2021
Merged

Natively get environment config to remove ember-get-config dependency #299

merged 6 commits into from
Mar 9, 2021

Conversation

fenichelar
Copy link
Owner

@fenichelar fenichelar commented Mar 3, 2021 •
edited
Loading

Fixes #297 and #298

@fenichelar fenichelar self-assigned this Mar 3, 2021
@fenichelar fenichelar mentioned this pull request Mar 3, 2021
Closed
@fenichelar
Copy link
Owner Author

v5.2.2

# Changelog

- Remove `ember-get-config` dependency #298
- Update documentation to not recommend using mixins #297
- Remove use of `ember-simple-auth` deprecated `data-adapter-mixin` #297
- Add support for `ember-cli-babel` v7

@fenichelar fenichelar requested a review from jpadilla March 3, 2021 01:25
@fenichelar fenichelar linked an issue Mar 3, 2021 that may be closed by this pull request
Request to update dependency on ember-get-config to 0.3.0 #298
Closed
@fenichelar
Copy link
Owner Author

@jpadilla when you get a chance, can you please review?

@fenichelar fenichelar merged commit e6b23e0 into fenichelar:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees

@fenichelar fenichelar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to update dependency on ember-get-config to 0.3.0 Release a version compatible with ESA v3.1.0
2 participants
@fenichelar @jpadilla