New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `PureRecord` and other Python classes to `feos.ideal_gas` #205

Merged

prehner merged 2 commits into main from pure_record_joback

Nov 30, 2023

Contributor

prehner commented Nov 30, 2023

This adds Identifier, IdentifierOption, PureRecord, and SegmentRecord to feos.ideal_gas.

In the short term this allows to handle ideal gas parameters like other models. For the future, there remain 3 issues:

In Python, we have a PureRecord for every model, which can lead to confusing errors or the requirement to rename imports.
The PureRecord in feos.ideal_gas refers to Joback specifically, so if we add more models, the naming will be awkward.
It might be more clear if non-generic Python classes (Identifier and IdentifierOption) are exported only once.


          Add PureRecord and other Python classes to feos.ideal_gas

324f4b3

prehner requested a review from g-bauer

November 30, 2023 09:24


          Add changelog entry

8ded307

prehner mentioned this pull request

QoL improvements for working with ideal gas models #203

Closed

g-bauer approved these changes

View reviewed changes

prehner merged commit 87272c3 into main

14 checks passed

prehner deleted the pure_record_joback branch

November 30, 2023 11:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet