Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure feos-core #226

Merged
merged 20 commits into from
Feb 26, 2024
Merged

Restructure feos-core #226

merged 20 commits into from
Feb 26, 2024

Conversation

g-bauer
Copy link
Contributor

@g-bauer g-bauer commented Feb 14, 2024

This PR restructures some elements of feos-core that make the code easier and a bit less opinionated.

  • Removal of the methods that return trait objects from Residual and IdealGas: the interface for the Helmholtz energy calculation no longer distinguishes between different contributions.
  • Consequently, we get rid of the traits and constructs to create object-safe traits.
  • Since the interface for the Helmholtz energy is less rigid we can think about efficiently calculating properties that are used across different contributions or even caching.

@prehner prehner marked this pull request as ready for review February 22, 2024 07:52
prehner
prehner reviewed Feb 22, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
examples/gc_pcsaft_functional.ipynb Outdated Show resolved Hide resolved
feos-core/src/density_iteration.rs Outdated Show resolved Hide resolved
feos-core/src/equation_of_state/helmholtz_energy.rs Outdated Show resolved Hide resolved
feos-core/src/equation_of_state/ideal_gas.rs Show resolved Hide resolved
src/pcsaft/eos/dispersion.rs Outdated Show resolved Hide resolved
src/pcsaft/eos/polar.rs Outdated Show resolved Hide resolved
src/pcsaft/eos/polar.rs Outdated Show resolved Hide resolved
src/pcsaft/eos/polar.rs Outdated Show resolved Hide resolved
src/saftvrqmie/eos/dispersion.rs Outdated Show resolved Hide resolved
@g-bauer g-bauer merged commit 150568d into main Feb 26, 2024
14 checks passed
@g-bauer g-bauer deleted the restructure_core branch February 26, 2024 12:14
@prehner prehner added this to the v0.7.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prehner prehner prehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@g-bauer @prehner