This fixes a bug introduced in jobsub_lite 1.7 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_SEC_CREDENTIAL_STORER is specified in the environment. Not doing this breaks POMS submissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #551, we changed the behavior of how the
_condor_SEC_CREDENTIAL_STORERenvironment variable was used. Previously, thecondor.py:submit()function would always coerce that environment variable to point to the jobsub_lite version ofcondor_vault_storer. #551 changed that so that if_condor_SEC_CREDENTIAL_STORERwas defined prior to submission, that setting was respected. This broke POMS submissions, as POMS relies on jobsub's overriding whatever setting for_condor_SEC_CREDENTIAL_STORERthat exists.Originally, that portion of #551 was put in place to allow us to pass verbose and debug to the underlying
condor_vault_storercommands for troubleshooting purposes. This PR keeps that behavior by using the user-passed--verbose/--debugflags while restoring the previous overriding of_condor_SEC_CREDENTIAL_STORER.I also added tests to make sure we didn't accidentally re-break this behavior in the future.