Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condor_submit_dag test #564

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix condor_submit_dag test #564

merged 1 commit into from
Apr 20, 2024

Conversation

marcmengel
Copy link
Contributor

It needed some environment variables passed; not sure how they were getting through before, but they aren't lately (alma9 container? condor update?) . Anyhow, I think the test works again now.

@marcmengel marcmengel requested a review from shreyb April 12, 2024 01:03
@shreyb
Copy link
Collaborator

shreyb commented Apr 12, 2024

LGTM, but one question. Do we know that this fixes the test?

@shreyb shreyb modified the milestones: 1.8, 1.8.1 Apr 12, 2024
@marcmengel
Copy link
Contributor Author

So I thought I answered this; yes this does fix it.

@shreyb shreyb modified the milestones: 1.8.1, 1.8 Apr 20, 2024
Copy link
Collaborator

@shreyb shreyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - the test worked for me.

@shreyb shreyb merged commit 9f3dda6 into master Apr 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants