Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept-headers: Support preference ordering #56

Merged
merged 1 commit into from
May 16, 2024
Merged

accept-headers: Support preference ordering #56

merged 1 commit into from
May 16, 2024

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes commented May 15, 2024 •
edited
Loading

Fixes content negotiation for Content Encodings - Namely supports parsing preferences ;q=FLOAT, and resolving across multiple headers. Inspired by #55.

@endocrimes endocrimes force-pushed the dani/content_negotiation branch 2 times, most recently from 15d655c to 0453bf2 Compare May 15, 2024 21:10
endocrimes
endocrimes commented May 15, 2024
View reviewed changes
src/lib.rs Show resolved Hide resolved
@endocrimes endocrimes requested a review from itowlson May 16, 2024 00:40
itowlson
itowlson approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of minor suggestions but nothing blocking. LGTM though it would be great if you could hold off until Joel can comment on the mutex. Thanks!

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
rylev
rylev approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we should aim to add a spin-test based test as soon as #55, but we don't need to necessarily block merging this PR on that one.

src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@endocrimes
accept-headers: Support preference ordering
c18f30d 
Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
@endocrimes endocrimes merged commit 0e35ba8 into fermyon:main May 16, 2024
2 checks passed
@endocrimes endocrimes deleted the dani/content_negotiation branch May 16, 2024 15:45
@rylev rylev mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicej dicej dicej left review comments

@rylev rylev rylev approved these changes

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endocrimes @itowlson @dicej @rylev