Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experience if it takes a while to download a "remote" component on spin up #2109

Closed
mikkelhegn opened this issue Nov 23, 2023 · 4 comments · Fixed by #2226
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@mikkelhegn
Copy link
Member

I was on an airplane, and I decided to run a Spin app using the fileserver, with a reference to Github in spin.toml. Now that took a while, as the bits of the fileserver was chasing the airplane across the Atlantic (I'm not sure they ever caught up). In those weird cases, it would be great if at spin up a note is fed back to the use, that Spin is currently busy downloading that remote component, so that it's easy to understand what we'er waiting for.

@itowlson itowlson added the good first issue Good for newcomers label Nov 23, 2023
@UtkarshUmre
Copy link

Hello @itowlson, I'm new here and interested in contributing! Could you please assign me this issue? It looks like a great first task for me

@itowlson
Copy link
Contributor

itowlson commented Jan 9, 2024

@UtkarshUmre Done - thanks for your enthusiasm!

Archisman-Mridha added a commit to Archisman-Mridha/spin that referenced this issue Jan 16, 2024
Signed-off-by: Archisman Mridha <archismanmridha12345@gmail.com>
Archisman-Mridha added a commit to Archisman-Mridha/spin that referenced this issue Jan 16, 2024
Signed-off-by: Archisman Mridha <archismanmridha12345@gmail.com>
@Archisman-Mridha
Copy link
Contributor

Archisman-Mridha commented Jan 16, 2024

Hi @itowlson, I am new to open-sourcing and this is my first time contributing to Fermyon Spin. I have opened a PR which solves this issue. Please let me know if I need to make any further changes or it's ready to be merged 😊.

@itowlson
Copy link
Contributor

@Archisman-Mridha Thanks! One thing to watch out for is if someone is already assigned - this can save folks from tripping over each others' toes - it might be worth checking in with @UtkarshUmre whether they are already working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants