Patched build.rs to run on systems without rustup. Added flake for ni… #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benwis Could you sign off the commit (and GPG sign if not already done) please? Thanks! |
itowlson
approved these changes
Dec 21, 2023
endocrimes
reviewed
Dec 21, 2023
flake.nix
Outdated
| @@ -0,0 +1,39 @@ | |||
|
|
|||
| { | |||
| description = "A basic Rust devshell"; | |||
There was a problem hiding this comment.
We should probably update this to reference spin, but that can be done as a follow up
There was a problem hiding this comment.
I mentioned spin in the new commit
I will try, I haven't setup code signing before, shouldn't be too bad |
…x devshell Signed-off-by: benwis <ben@celcyon.com>
Signed-off-by: benwis <ben@celcyon.com>
Signed! |
endocrimes
approved these changes
Dec 21, 2023
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build spin on systems without rustup, you can't use rustup to check for targets. I've replaced that check with one from rustc. If it's not installed it still fails for nix users as it can't install it, but if it is it passes at least