-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rest of e2e tests over to new testing framework #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
more-e2e
branch
2 times, most recently
from
January 12, 2024 14:42
79b501a
to
52a1d56
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
more-e2e
branch
3 times, most recently
from
January 12, 2024 15:03
b6dd3ce
to
70cb41a
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rylev
force-pushed
the
more-e2e
branch
6 times, most recently
from
January 15, 2024 13:25
96e9fb9
to
9c6117f
Compare
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
rajatjindal
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all e2e tests over to the new testing framework. See #2223 for more details on what this involves.
The e2e tests are not really factored as a testing framework but rather a loose collection of functions that use the lower-level testing framework to build up there tests. There is definitely room for improvement here to make adding e2e tests even easier, but for now, it's a relief to see that writing these tests with the low-level framework is actually fairly straight-forwarded.
As an example, here's the most complicated e2e test we currently have which tests whether running an app from a registry works: