Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Spin v2.2 version bumps #2260

Merged
merged 2 commits into from
Jan 30, 2024
Merged

chore(release): Spin v2.2 version bumps #2260

merged 2 commits into from
Jan 30, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Jan 30, 2024

No description provided.

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice vdice requested review from dicej and itowlson January 30, 2024 20:37
@vdice
Copy link
Member Author

vdice commented Jan 30, 2024

Oops, seeing the following from the Lint Rust job:

...
M	tests/test-components/components/Cargo.lock
Git working tree dirtied by lints. Run 'make update-cargo-locks' and check in changes

Alas, make update-cargo-locks currently only appears to update files under examples... Do we need to add tests as well?

@itowlson
Copy link
Contributor

@vdice Huh. We never used to have to do tests but I guess something changed...

Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
@vdice
Copy link
Member Author

vdice commented Jan 30, 2024

I pushed a commit manually running cargo update -w --offline in tests/test-components/components: 8f9f5af. We'll see if that suffices for our needs here.

@vdice vdice merged commit eebfae1 into v2.2 Jan 30, 2024
11 checks passed
@vdice vdice deleted the chore/v2.2-bumps branch January 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants