Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warning for uncomponentizable modules #2571

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add deprecation warning for uncomponentizable modules #2571

merged 1 commit into from
Jun 17, 2024

Conversation

lann
Copy link
Collaborator

@lann lann commented Jun 17, 2024 •
edited
Loading

See #2552

$ spin up
...

!!! DEPRECATION WARNING !!!
The Wasm module at /path/to/your/wasm/module.wasm
appears to have been compiled with wasi-sdk version <19 and is likely to
contain a critical memory safety bug. Spin has deprecated execution of these
modules; they will stop working in a future release.
For more information, see: https://github.com/fermyon/spin/issues/2552

...

@lann lann mentioned this pull request Jun 17, 2024
Closed
@lann lann force-pushed the uncomponentizable-modules branch 2 times, most recently from 0ad0ac0 to 1236ccf Compare June 17, 2024 21:41
@lann lann enabled auto-merge June 17, 2024 21:46
itowlson
itowlson approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the new issue wording is super helpful!

@vdice vdice mentioned this pull request Jun 17, 2024
Merged
1 task
@vdice
Copy link
Member

vdice commented Jun 17, 2024

Needs a quick make update-cargo-locks invocation...

@lann
Add deprecation warning for uncomponentizable modules
9860251 
Signed-off-by: Lann Martin <lann.martin@fermyon.com>
@lann lann force-pushed the uncomponentizable-modules branch from 1236ccf to 9860251 Compare June 17, 2024 23:17
@lann lann merged commit b01f21a into fermyon:main Jun 17, 2024
17 checks passed
@lann lann deleted the uncomponentizable-modules branch June 18, 2024 13:26
This was referenced Jun 18, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@dicej dicej dicej approved these changes

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lann @vdice @itowlson @dicej @fibonacci1729