Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional languages and toolchains #368

Merged
merged 1 commit into from Apr 17, 2022
Merged

Add additional languages and toolchains #368

merged 1 commit into from Apr 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2022

This PR adds a couple of languages and toolchains that support WebAssembly. See #198.

  • Go
  • Go Language Server (gopls)
  • TinyGo
  • rust-analyzer
  • Grain
  • AssemblyScript

@ghost ghost marked this pull request as draft April 17, 2022 20:07
@ghost ghost changed the title Add additional languages and toolchains (closes #198) Add additional languages and toolchains Apr 17, 2022
# Install additional rust components (rust-analyzer)
ARG RUST_ANALYZER_URL="https://github.com/rust-lang/rust-analyzer/releases/download/2022-04-11/rust-analyzer-x86_64-unknown-linux-gnu.gz"
RUN curl -sL "$RUST_ANALYZER_URL" | gunzip -c - > /usr/local/bin/rust-analyzer && chmod +x /usr/local/bin/rust-analyzer
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably prefer to use rustup component add rust-analyzer here but it seems like rust-analyzer was added and then removed temporarily til it's stable, see rust-lang/rustup#2560

"fermyon.autobindle",
"golang.Go",
"grain-lang.vscode-grain",
"saulecabrera.asls"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the more active VS Code extension from Shopify: https://github.com/Shopify/vscode-as

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this preferred for AssemblyScript vs. the regular JavaScript / TypeScript extension?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I can reach out to folks in the AssemblyScript Discord and see what they've been using/prefer.

Copy link
Author

@ghost ghost Apr 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it probably makes sense to just use the regular JavaScript / TypeScript extension by Microsoft (https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-next). If there's a recommendation from the AS core team, I can open up a follow-up.

EDIT: will follow-up in another PR if consensus is to use the regular extension

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is configured by default anyway.
Let's see if using the AssemblyScript tooling is an improvement, there are quite a things not caught by the JS language server when writing AssemblyScript.

@ghost ghost marked this pull request as ready for review April 17, 2022 21:11
@ghost
Copy link
Author

ghost commented Apr 17, 2022

I think this PR is now ready for review. I have not tested the vs code integration, but I've tested and confirmed that each of the added language and toolchain is available inside the container (I did this by just running a --help or --version while inside the container)

@radu-matei
Copy link
Member

This looks good to me.
Could you please rebase and squash the commits?

Thanks!

@ghost
Copy link
Author

ghost commented Apr 17, 2022

Done!

@radu-matei radu-matei merged commit 14603bb into fermyon:main Apr 17, 2022
@ghost ghost deleted the 0xcodeboi/add-toolchains-to-dev-container branch April 17, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants