Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature suggestion: Allow user to set redirect options for the bucket #21

Closed
linusmarco opened this issue Feb 5, 2018 · 5 comments
Closed

Feature suggestion: Allow user to set redirect options for the bucket #21

linusmarco opened this issue Feb 5, 2018 · 5 comments
Assignees
@linusmarco

Comments

@linusmarco
Copy link
Contributor

Now that the plugin allows for custom index and error documents ( #20 ), I think the next logical step on that path would be to allow users to specify the other two website configuration options: RedirectAllRequestsTo and RoutingRules (docs). Personally, I use routing/redirect rules on occasion, so it would be great to have the option to do this via the plugin (especially because these options get reset upon deploy currently).

I'd be happy to submit a PR for this if it's something that you think you'd want to include.
@fernando-mc
Copy link
Owner

@linusmarco I have to think on this one a little. One thing I want to eventually move this plugin towards is handing custom domains, CloudFront distributions, and SSL certs.

I'm generally open to ideas that don't interfere with the default behavior. But I've not used those specific config options before. I'm assuming that they wouldn't really get in the way of that sort of functionality if they we're optional right?

If so, go for it on the PR front. I will warn you that I've been horribly truant on reviewing, testing, and approving PRs but I'm hoping to get a better release cycle soon.

@linusmarco
Copy link
Contributor Author

Okay, sounds good. Thanks for the feedback, @fernando-mc. These options shouldn't get in the way of any already-existing functionality. I'll work on it and submit a PR. No worries if takes a while to approve. The direction you're heading sounds awesome--that would be very useful. I'll be happy to pitch in with other contributions going forward.

@fernando-mc
Copy link
Owner

Sounds great @linusmarco ! Honestly, the toughest part for me right now has been testing to make sure new PRs don't break existing functionality. If you have suggestions to streamline that I'd love your thoughts.

Don't get me wrong though, any PRs for new functionality will be very much appreciated!

linusmarco added a commit to linusmarco/serverless-finch that referenced this issue Feb 20, 2018
@linusmarco
add ability to specify redirect rules for hosted bucket (closes ferna…
1cb694c 
…ndo-mc#21)
linusmarco added a commit to linusmarco/serverless-finch that referenced this issue Feb 20, 2018
@linusmarco
add ability to specify redirect rules for hosted bucket (closes ferna…
91afab9 
…ndo-mc#21)
@linusmarco linusmarco mentioned this issue Feb 20, 2018
Closed
@fernando-mc
Copy link
Owner

This is related to one of the PRs I think I dropped the ball on. Assigning back to you to peek over after we merge/publish v2.

@linusmarco
Copy link
Contributor Author

You didn't drop the ball at all--this was actually addressed in the refactor (#43) 😃. I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linusmarco linusmarco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fernando-mc @linusmarco