Add CLI params for disabling deleting and config/policy/cors updates #28
Conversation
|
I personally love this. Could you add some more information to the |
| @@ -46,7 +46,7 @@ echo "error page" >> client/dist/error.html | |||
| **Fourth**, run the plugin, and visit your new website! | |||
|
|
|||
| ``` | |||
| serverless client deploy [--stage $STAGE] [--region $REGION] | |||
| serverless client deploy [--stage $STAGE] [--region $REGION] [--no-delete-contents] [--no-config-change] [--no-policy-change] [--no-cors-change] | |||
There was a problem hiding this comment.
Does the no in all the flags get removed somewhere?
These options make sense to me. Just have to figure out how to refactor some of the documentation to explain these options. And also decide if these make sense as command line args or as config details in serverless.yml.
| @@ -31,6 +31,7 @@ class Client { | |||
| this.serverless = serverless; | |||
| this.provider = 'aws'; | |||
| this.aws = this.serverless.getProvider(this.provider); | |||
| this.options = options; | |||
There was a problem hiding this comment.
Can you remove the tabs and add in spaces everywhere? You can review in GitHub to compare the spacing here.
|
When you get around to making an update to this can you also please bring in the style fixes and recent changes to resolve conflicts? |
|
@orm-forks, if you have any questions or need any help merging the recent linting/docs changes into this PR, just let me know. |
|
+1 This would be excellent to have! Can someone else please fix this if the author doesn't do it soon? |
|
I'm working on a major rewrite of the library that should be done soon. I can probably incorporate this into that PR |
…es (resolves fernando-mc#28 and resolves fernando-mc#15)
* split up code more logically, get bucket removal working * finish up refactor * more refactoring * split out configure functions into separate file * add object metadata functionality back in * fix typo in README * start log of changes for v2.0.0 * re-allow command-line region option, update log messages * adding CLI params for disabling deleting and config/policy/cors updates (resolves #28 and resolves #15) * add routing options in * finish off validation for all configuration options * update changelog * update changelog again and add myself as maintainer * addressing fernando's code review comments * comment out all tests for now -- will be rewritten * add confirmation prompts on deploy and remove
|
@tim-stasse This is now live in v2.0.0! |
We have added a bit more flexibility in what the plugin does to the S3 bucket as part of the flow.