Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As I suggested in #30, the format of the documentation in the README needs to be changed to allow for the growing number of configuration settings. I think it's also a good idea to lay out a more formal set of guidelines/processes for issues and PRs (basically codifying and fleshing out what @fernando-mc laid out in a comment on #37).
Proposed changes
examples
folderAlso, @fernando-mc had expressed concern about how to structure nested options. I would suggest that we deal with that by providing docs 'sections' only for top-level options, and specifying sup-option definitions in the same section like so (example for object headers PR):
objectHeaders
optional, no default
Use the
objectHeaders
option to set HTTP response headers be sent to clients requesting uploaded files from your website.Headers may be specified globally for all files in the bucket by adding a
headerName
,headerValue
pair to theALL_OBJECTS
property of theobjectHeaders
option. They may also be specified for specific folders or files within your site by specifying properties with names likespecific-directory/
(trailing slash required to indicate folder) orspecific-file.ext
, where the folder and/or file paths are relative todistributionFolder
.Headers with more specificity will take precedence over more general ones. For instance, if 'Cache-Control' was set to 'max-age=100' in
ALL_OBJECTS
and to 'max-age=500' inmy/folder/
, the files inmy/folder/
would get a header of 'Cache-Control: max-age=500'.Proposed reviewers (optional)