Port Rails 6 time fix #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's relatively easy for this to happen by accident (e.g. time drift on a rogue server), and it throws a spanner in the works if you're monitoring for oldest job in the queue.
This method wasn't making use of the que_jobs.args index and was performing badly on large datasets. GIN indexes don't support the '=' operator, but support existence '?' and containment '@>' among others. To make use of the index the query has to check for containment of a subset document rather than match a value within the document directly. QueJob#by_job_args is already querying in this way; this change makes QueJob#by_job_class consistent with it. Context: https://www.postgresql.org/docs/9.6/datatype-json.html#JSON-INDEXING Given a jsonb column "data" indexed as follows: CREATE INDEX data_index ON table USING GIN (data); And with data in this format: { "name": "Melbourne", "type": "City" } This query will make use of the index: SELECT data FROM table WHERE data @> '{"name": "Melbourne"}'; But this one will not: SELECT data FROM table WHERE data->>'name' = "Melbourne";
Improve QueJob#by_job_class performance.
In Rails 6 we get `no implicit conversion of Time into String` when enqueueing jobs. This was patched upstream, see [here](que-rb#247).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 6 we get
no implicit conversion of Time into Stringwhen enqueueing jobs. This was patched upstream, see here.