-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: base64url support #314
base: master
Are you sure you want to change the base?
Conversation
I also need base64url encoding support for my project, |
Any news for this ? Please. |
same issue, any news? |
Thanks for coding this, @jrschumacher! Using it for a fork |
I need base64url encoding support for my project, can we review and merge this ASAP? |
It's probably not going to happen if it's been this long. Just use my branch or just wrap the base64 function in a string replace. |
Hopefully this is merged some day. It seems to work well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll need to resolve the CI issues before I can merge though
@dcousens I removed trailing spaces on line 955 of index.js |
@dcousens still interested in taking this? |
Using string replaceAll since base64 is external base64-js. Dependency does not yet support base64url beatgammit/base64-js#53
4da50f9
to
f22ba44
Compare
I rebased with the master branch and removed my lint scripts from the package.json to reduce conflicts. |
Thanks @jrschumacher, I'm happy to take this from here next I can, I need to check in on @chjj's pull request in #349, which might supersede this |
Would it be possible to merge and release this first since the other PR seems stuck for a long time now? |
Using string replaceAll since base64 is external base64-js.
Dependency does not yet support base64url beatgammit/base64-js#53