Insert replacement characters like node does when converting UTF8 bytes to String #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review today |
|
Cool, thanks. I just installed node@3 and I see now it is replacing things in the surrogate pair range - pushing a test and fix for that now.. |
jessetane
force-pushed
the
utf8-replacement-chars
branch
from
05d07dd
to
3e1bdd0
Compare
|
LGTM. Waiting for @dcousens. Feel free to merge when it looks good. Then I'll do a release. |
|
LGTM. Nice implementation, I might break down down some of the indentation through the use of |
dcousens
added a commit
that referenced
this pull request
Aug 11, 2015
Insert replacement characters like node does when converting UTF8 bytes to String
|
Published as 3.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #66