Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 233 open source collectives from opencollective.com db #23

Merged
merged 3 commits into from
Feb 10, 2018

Conversation

xdamman
Copy link
Contributor

@xdamman xdamman commented Feb 9, 2018

Thank you for your work! 🙏

Let me know if I can help in any other way.

@xdamman
Copy link
Contributor Author

xdamman commented Feb 9, 2018

FYI: I did a quick script to pull all open source projects on open collective and check their package.name on their package.json.
258 didn't have a package.json file on their repo (so about 50%)

@xdamman
Copy link
Contributor Author

xdamman commented Feb 9, 2018

Huh, tests don't pass because "strings must use single quotes", but it's not proper JSON to use single quotes (my script exported the data as JSON)

@xdamman
Copy link
Contributor Author

xdamman commented Feb 9, 2018

alright, changing double quotes to single quotes ;-)

Copy link
Owner

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this as-is for now. I'll remove the 'undefined' field manually.

'slim-js': 'https://opencollective.com/slimjs',
'ng2-date-picker': 'https://opencollective.com/angular-datepicker',
'esdiscuss.org': 'https://opencollective.com/esdiscuss',
'undefined': 'https://opencollective.com/turf',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an error!

I'm guessing that this is caused by their root package.json not having a "name" field. See here: https://github.com/Turfjs/turf/blob/master/package.json

I think this is actually pretty common for mono-repo projects. https://github.com/Turfjs/turf/blob/master/packages/turf/package.json

I wonder if this happened more than once in your script. If that happened, then you'd have overwritten the 'undefined' field multiple times and many projects may have not made it into this dump. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. Yes just remove that line. If they don’t have a name in their package.json there is no way you can do anything with it anyway. So not much we can do here.

@feross feross merged commit 65d6c65 into feross:master Feb 10, 2018
@feross feross mentioned this pull request Feb 10, 2018
@xdamman
Copy link
Contributor Author

xdamman commented Feb 10, 2018

Thanks for merging!

@feross
Copy link
Owner

feross commented Feb 10, 2018

@xdamman Yep! Any chance you could regularly publish this list as a standalone npm package? This would make it easy to keep this list up-to-date.

For inspiration, take a look at some of the @nice-registry projects: https://github.com/nice-registry/all-the-package-repos

@xdamman
Copy link
Contributor Author

xdamman commented Feb 10, 2018

Doesn't scale very well. I'd prefer finding a more scalable solution like the one being discussed here: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants