Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEA-242 Local push and publish commands re-implemented to use context generat… #612

Merged
merged 8 commits into from
Jan 10, 2020
Merged

AEA-242 Local push and publish commands re-implemented to use context generat… #612

merged 8 commits into from
Jan 10, 2020

Conversation

panasevychol
Copy link
Contributor

@panasevychol panasevychol commented Jan 9, 2020 •
edited by DavidMinarsch
Loading

…ed value of packages path. Tests fixed.

Fixes

The variable DEFAULT_REGISTRY_PATH was changed not to be used as a path to packages folder anymore so the push and publish functionality that was using it was broken. By request it's re-implemented "exactly like in search command". Tests updated.

#601

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@panasevychol panasevychol added the cli Issues related to the CLI tool `aea` label Jan 9, 2020
@panasevychol panasevychol self-assigned this Jan 9, 2020
DavidMinarsch
DavidMinarsch suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please see comments

aea/cli/push.py Outdated Show resolved Hide resolved
aea/cli/push.py Outdated Show resolved Hide resolved
aea/cli/push.py Outdated Show resolved Hide resolved
aea/cli/push.py Outdated Show resolved Hide resolved
panasevychol
panasevychol commented Jan 10, 2020
View reviewed changes
aea/cli/fetch.py Show resolved Hide resolved
aea/cli/publish.py Outdated Show resolved Hide resolved
aea/cli/registry/fetch.py Show resolved Hide resolved
aea/cli/registry/publish.py Show resolved Hide resolved
aea/cli/registry/push.py Show resolved Hide resolved
DavidMinarsch
DavidMinarsch approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit aab127c into develop Jan 10, 2020
@DavidMinarsch DavidMinarsch deleted the bugfix/local-save-path branch January 11, 2020 12:47
@DavidMinarsch DavidMinarsch changed the title Local push and publish commands re-implemented to use context generat… AEA-242 Local push and publish commands re-implemented to use context generat… Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch approved these changes

Assignees

@panasevychol panasevychol

Labels
cli Issues related to the CLI tool `aea`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panasevychol @DavidMinarsch