Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEA-444 Small update in the thermometer demo. #937

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Conversation

Totoual
Copy link
Contributor

@Totoual Totoual commented Mar 17, 2020

Proposed changes

Added a Note in the guide to inform that we have to change the config.

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #937 into develop will increase coverage by 4.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #937      +/-   ##
===========================================
+ Coverage    91.08%   95.93%   +4.84%     
===========================================
  Files          120      120              
  Lines         8954     8948       -6     
===========================================
+ Hits          8156     8584     +428     
+ Misses         798      364     -434     
Flag Coverage Δ
#unittests 95.93% <ø> (+4.84%) ⬆️
Impacted Files Coverage Δ
aea/cli_gui/__init__.py 87.54% <0.00%> (+0.24%) ⬆️
aea/configurations/base.py 100.00% <0.00%> (+0.31%) ⬆️
aea/protocols/generator.py 96.14% <0.00%> (+52.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d42fc...91cdb99. Read the comment docs.

@@ -132,6 +132,8 @@ aea config set vendor.fetchai.skills.thermometer.models.strategy.args.currency_i
aea config set vendor.fetchai.skills.thermometer.models.strategy.args.ledger_id ethereum
```

NOTE: If you are not using a Raspberry Pi make sure you make the `has_sensor` setted to `False`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: If you are not using a Raspberry Pi make sure you set the has_sensorattribute toFalse`

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit d3d959d into develop Mar 18, 2020
@Totoual Totoual deleted the fix/doc_update branch March 18, 2020 17:33
@DavidMinarsch DavidMinarsch changed the title Small update in the thermometer demo. AEA-444 Small update in the thermometer demo. Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants