-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AEA-443 prepare develop for v0.2.3 #946
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #946 +/- ##
===========================================
+ Coverage 96.16% 96.23% +0.06%
===========================================
Files 120 120
Lines 8911 8913 +2
===========================================
+ Hits 8569 8577 +8
+ Misses 342 336 -6
Continue to review full report at Codecov.
|
@@ -17,28 +17,28 @@ | |||
# | |||
# ------------------------------------------------------------------------------ | |||
|
|||
"""This module contains test_protocol's message definition.""" | |||
"""This module contains t_protocol's message definition.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing names to avoid clashes with pytest loading module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pipfile
Outdated
@@ -13,14 +13,18 @@ bandit = "==1.6.2" | |||
black = "==19.10b0" | |||
bs4 = "==0.0.1" | |||
colorlog = "==4.1.0" | |||
docker = "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a specific version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
This PR restructures the docs based on feedback and upgrades the version.
Fixes
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.aea cli
tool worksFurther comments