Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEA-443 prepare develop for v0.2.3 #946

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Conversation

DavidMinarsch
Copy link
Contributor

Proposed changes

This PR restructures the docs based on feedback and upgrades the version.

Fixes

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@codecov-io
Copy link

Codecov Report

Merging #946 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
+ Coverage    96.16%   96.23%   +0.06%     
===========================================
  Files          120      120              
  Lines         8911     8913       +2     
===========================================
+ Hits          8569     8577       +8     
+ Misses         342      336       -6
Flag Coverage Δ
#unittests 96.23% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
aea/__version__.py 100% <100%> (ø) ⬆️
aea/crypto/ethereum.py 100% <0%> (ø) ⬆️
packages/fetchai/connections/local/connection.py 99.5% <0%> (ø) ⬆️
aea/protocols/generator.py 99.37% <0%> (+0.25%) ⬆️
aea/cli_gui/__init__.py 87.54% <0%> (+0.32%) ⬆️
aea/decision_maker/base.py 100% <0%> (+0.63%) ⬆️
aea/helpers/base.py 100% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57b7cf...aae6ae8. Read the comment docs.

@@ -17,28 +17,28 @@
#
# ------------------------------------------------------------------------------

"""This module contains test_protocol's message definition."""
"""This module contains t_protocol's message definition."""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing names to avoid clashes with pytest loading module.

Copy link
Contributor

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Pipfile Outdated
@@ -13,14 +13,18 @@ bandit = "==1.6.2"
black = "==19.10b0"
bs4 = "==0.0.1"
colorlog = "==4.1.0"
docker = "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a specific version here?

Copy link
Contributor

@Totoual Totoual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit 0404c8d into develop Mar 19, 2020
@DavidMinarsch DavidMinarsch deleted the feature/release_v0.2.3 branch March 22, 2020 09:09
@DavidMinarsch DavidMinarsch changed the title prepare develop for v0.2.3 AEA-443 prepare develop for v0.2.3 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants