Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): updates to mailbox and agentverse registration process #588

Merged
merged 18 commits into from
Dec 12, 2024

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Dec 4, 2024

Proposed Changes

  • Add updates for new mailbox connection workflow
  • Add support for proxy and custom agent registration
  • Remove websocket connection, which hasn't been supported for a long time anyway
  • Delete mailbox messages immediately after handling them instead of processing them in a queue
  • Handle CORS preflight request

Linked Issues

[if applicable, add links to issues resolved by this PR]

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

@jrriehl jrriehl changed the title feat(core): updates to mailbox and agentverse registration response feat(core): updates to mailbox and agentverse registration process Dec 4, 2024
python/src/uagents/agent.py Outdated Show resolved Hide resolved
@jrriehl jrriehl marked this pull request as ready for review December 9, 2024 17:09
Dacksus
Dacksus previously approved these changes Dec 10, 2024
python/src/uagents/mailbox.py Show resolved Hide resolved
python/examples/11-mailbox-agents/bob.py Show resolved Hide resolved
Copy link
Contributor

@Dacksus Dacksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding the tests, otherwise LGTM! Creating a mailbox/proxy agent now feels much cleaner with the boolean options and the AgentverseConfig

python/tests/test_config.py Show resolved Hide resolved
@jrriehl jrriehl merged commit 11238ad into main Dec 12, 2024
9 checks passed
@jrriehl jrriehl deleted the feat/agentverse-updates branch December 12, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants