Merge pull request #31 from fewieden/develop

2.2.1

.eslintrc

@@ -5,7 +5,7 @@
         "sourceType": "module"
     },
     "settings": {
-        "import/core-modules": [ "node_helper" ]
+        "import/core-modules": ["logger", "node_helper"]
     },
     "env": {
         "browser": true,
@@ -28,7 +28,6 @@
         "curly": ["error", "all"],
         "array-bracket-spacing": 0,
         "space-before-function-paren": 0,
-        "object-curly-spacing": ["error", "never"],
         "object-property-newline": ["error", { "allowAllPropertiesOnSameLine": true }]
     }
 }

.github/CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 Thanks for contributing to this module!
 
-Please create pull requests to the branch `develop`.
+Please create pull requests towards the branch `develop`.
 
-To hold one code style and standard there are several linters and tools in this project set. Make sure you fulfill the requirements.
-Also, there will be automatically analysis performed once you created the pull request.
+To hold one code style and standard there are several linters and tools in this project configured. Make sure you fulfill the requirements.
+Also, there will be an automatic analysis performed once you create the pull request.

.github/FUNDING.yml

@@ -1 +1,2 @@
+github: fewieden
 custom: ['https://paypal.me/fewieden']

.github/workflows/build.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [ 14.x ]
+        node-version: [ 16.x ]
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}

.stylelintrc

@@ -1,6 +1,10 @@
 {
     "extends": "stylelint-config-standard",
     "rules": {
-        "indentation": 4
+        "indentation": 4,
+        "selector-class-pattern": [
+            "^([a-z][a-z0-9]*|MMM-NHL)(-[a-z0-9]+)*$",
+            {"message": "Expected class selector to be kebab-case"}
+        ]
     }
 }

CHANGELOG.md

@@ -1,5 +1,24 @@
 # MMM-NHL Changelog
 
+## [2.2.0]
+
+MagicMirror² version >= 2.15.0 required.
+
+### Added
+
+* Added new config option `showPlayoffSeries` to display playoff series information
+
+### Changed
+
+* Node helper logs are now done through MagicMirror logger
+* Updated project config files
+* Updated Github config files
+
+### Fixed
+
+* Changed Logo Urls to support all teams (specifically all-star teams)
+* Added support for teams with no short name when showNames is true
+
 ## [2.1.0]
 
 ### Fixed

MMM-NHL.css

@@ -10,7 +10,6 @@
 }
 
 .MMM-NHL .no-color {
-    -webkit-filter: grayscale(100%);
     filter: grayscale(100%);
 }
 

MMM-NHL.js

@@ -45,9 +45,11 @@ Module.register('MMM-NHL', {
         '3rd': '3RD_PERIOD',
         OT: 'OVER_TIME',
         SO: 'SHOOTOUT',
+        SHOOTOUT: 'SHOOTOUT',
         FINAL: 'FINAL',
         'FINAL OT': 'FINAL_OVERTIME',
-        'FINAL SO': 'FINAL_SHOOTOUT'
+        'FINAL SO': 'FINAL_SHOOTOUT',
+        PPD: 'PPD'
     },
 
     /**
@@ -58,6 +60,12 @@ Module.register('MMM-NHL', {
      * @member {Game[]} games - List of all games matching focus and timespan config options.
      */
     games: [],
+
+    /**
+     * @member {Series[]} playoffSeries - List of all current playoff series.
+     */
+    playoffSeries: [],
+
     /**
      * @member {SeasonDetails} season - Current season details e.g. year and mode.
      */
@@ -83,6 +91,7 @@ Module.register('MMM-NHL', {
      * @property {number} daysAhead - Amount of days a match should be displayed before it starts.
      * @property {boolean} showNames - Flag to show team names.
      * @property {boolean} showLogos - Flag to show club logos.
+     * @property {boolean} showPlayoffSeries - Flag to show playoff series status during playoffs.
      * @property {boolean} rollOverGames - Flag to show today's games and previous/next day based on game status.
      */
     defaults: {
@@ -96,6 +105,7 @@ Module.register('MMM-NHL', {
         daysAhead: 7,
         showNames: true,
         showLogos: true,
+        showPlayoffSeries: true,
         rollOver: false
     },
 
@@ -149,6 +159,7 @@ Module.register('MMM-NHL', {
             modes: this.modes,
             season: this.season,
             games: this.games,
+            playoffSeries: this.playoffSeries,
             rotateIndex: this.rotateIndex,
             maxGames: Math.min(this.games.length, this.rotateIndex + this.config.matches),
             config: this.config
@@ -171,7 +182,7 @@ Module.register('MMM-NHL', {
             this.config.daysAhead = 1;
         }
 
-        this.sendSocketNotification('CONFIG', {config: this.config});
+        this.sendSocketNotification('CONFIG', { config: this.config });
     },
 
     /**
@@ -188,6 +199,9 @@ Module.register('MMM-NHL', {
             this.games = payload.games;
             this.season = payload.season;
             this.setRotateInterval();
+        } else if (notification === 'PLAYOFFS') {
+            this.playoffSeries = payload;
+            this.updateDom(300);
         }
     },
 

README.md

@@ -4,7 +4,7 @@ National Hockey League Module for MagicMirror<sup>2</sup>
 
 ## Examples
 
-![](.github/example_nhl.png) ![](.github/example_nhl_2.png) ![](.github/example_nhl_3.png)
+![](.github/example_nhl.png) ![](.github/example_nhl_2.png) ![](.github/example_nhl_3.png) ![](.github/example_nhl_4.png) ![](.github/example_nhl_5.png)
 
 ## Dependencies
 
@@ -43,6 +43,7 @@ National Hockey League Module for MagicMirror<sup>2</sup>
 | `liveReloadInterval` | `60000 (1 min)` | How often should the data be fetched during a live game. |
 | `showNames` | `true` | Should team names be displayed? |
 | `showLogos` | `true` | Should team logos be displayed? |
+| `showPlayoffSeries` | `true` | Should playoff series be displayed (if in playoffs)? |
 | `rollOver` | `false` | Displays today's games and based on game status also yesterdays games or tomorrows games. Automatically overrides `daysInPast` and `daysAhead` to 1. |
 
 ## Global config