Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 #12

Merged
merged 44 commits into from
Jan 25, 2021
Merged

v2 #12

merged 44 commits into from
Jan 25, 2021

Conversation

fewieden
Copy link
Owner

Added

  • Nunjuck templates
  • French translations thanks to matlem037
  • Dependency node-fetch

Changed

  • Switched API for data feed.
  • Display logos from remote.
  • Retrieve team list from API.
  • ESLint recommended instead of airbnb ruleset.

Removed

  • Config option format, instead rendering information based on locale.
  • Dependency moment-timezone
  • Dependency request
  • Local team logos

@fewieden
Copy link
Owner Author

fewieden commented Jan 17, 2021

@dannoh I was working on extracting the calendar filter into a nunjuck template as well in order to provide the same information for live games. I couldn't get include nor import work in combination with the for loop. However, I still plan to add that functionality into the template in the next few days.

Things to do before release:

  • Add config options:
    • liveReloadInterval (1 min)
    • showNames (true)
    • showLogos (true)
    • daysInPast (1)
    • daysAhead (7)
  • Clean up unused translations
  • Extract calendar filter and provide the same functionality as with v1 of module for the table column
  • Support for postponed games?
  • Replace Travis with GitHub actions
  • Add documentation
  • Github action to check for edited changelog
  • Fix code climate issues

@fewieden
Copy link
Owner Author

@dannoh I made some more progress today.

  • Moved the calendar column to the nunjuck template file itself. Also changed the display of the live games (should now also support overtime and shootout mode), maybe you can give some feedback the next days if it works.
    The final game state now also supports final ot and final so, which didn't work since I changed the API, but I checked it with changing daysInPast option to 4.
  • Documented your new config options
  • Cleaned up translations

@dannoh
Copy link
Contributor

dannoh commented Jan 21, 2021

I'll pull your stuff today and try it out

@fewieden fewieden merged commit 3bda579 into master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants