Skip to content

Commit

Permalink
Update README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
fewieden authored Oct 17, 2018
1 parent 08e3808 commit 8c2d6f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ European Soccer Standings Module for MagicMirror²
| `show` | 'GERMANY' | Which league should be displayed 'GERMANY', 'FRANCE', 'ENGLAND', 'SPAIN' or 'ITALY' |
| `focus_on` | false | Which team should the standings focus on per league e.g. {"GERMANY": "FC Bayern München", "FRANCE": "Olympique Lyonnais"}. Omit this option or set to false to show the full league table. |
| `max_teams` | false | How many teams should be displayed. Omit this option or set to false to show the full league table. |
| `leagues` | `{"GERMANY":430, "FRANCE": 434, "ENGLAND": 426, "SPAIN": 436, "ITALY": 438}` | A collection of leagues obtained from <http://api.football-data.org/v1/competitions> |
| `leagues` | `{"GERMANY": "BL1", "FRANCE": "FL1", "ENGLAND": "PL", "SPAIN": "PD", "ITALY": "SA"}` | A collection of leagues obtained from <http://api.football-data.org/v2/competitions> |
| `logos` | `false` | Boolean to show club logos or not. |
## Logos
Expand Down

6 comments on commit 8c2d6f0

@adriennekline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please explain how to configure the file for use? Am I supposed to be configuring it in the MMM-soccer.js file or the config.js file? as in your explanation there is just ... in the config.js file

@fewieden
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriennekline you should never touch the module files from any module as a base rule. All configuation should always happen inside the config.js file as it overwrites the one inside the module defaults. They are only active as a default in case you dont specify them in the config explicitly

@andreas-farrugia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I'm trying to use this module and it worked but logos didn't. I've tried your installation method and logos did not show up, only a default icon. How can I use the assigned logo of the particular league teams please? Thanks, hope to hear from you soon

@fewieden
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasf98 the logos get taken down from wikimedia to frequent to provide always an up to date list for all leagues. You could download the logos for the required teams and place them in the public dir as described in the docs https://github.com/fewieden/MMM-soccer#logos

@andreas-farrugia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasf98 the logos get taken down from wikimedia to frequent to provide always an up to date list for all leagues. You could download the logos for the required teams and place them in the public dir as described in the docs https://github.com/fewieden/MMM-soccer#logos

And do I have to code something to get the logos from the public dir please?
If so which code reference should I write? Thanks

@fewieden
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasf98 there is no code required. The logic is already defined to check the public directory here

<td><img class="icon {% if not config.colored %}no-color{% endif %}" src="/MMM-soccer/{{standing[index].team.name}}.svg"/></td>

E.g. for the german bundesliga it should look something like:

mmm-soccer

Please sign in to comment.