Ensure proper cleanup of subscribers #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of server shutdown, this change ensures that we abort the tasks responsible for handling client connections before fully shutting down. This allows the named pipe connections to be dropped properly. (Fixes #13) In the case of a client disconnection at any point in the message loop for the subscriber, the server will ensure that the disconnect is handled instead of exiting the subscriber handler immediately. This fixes a rare issue wherein the server does not exit when the last client disconnects because the disconnection happened while the server is sending a message to the subscriber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of server shutdown, this change ensures that we abort the tasks responsible for handling client connections before fully shutting down. This allows the named pipe connections to be dropped properly. (Fixes #13)
In the case of a client disconnection at any point in the message loop for the subscriber, the server will ensure that the disconnect is handled instead of exiting the subscriber handler immediately. This fixes a rare issue wherein the server does not exit when the last client disconnects because the disconnection happened while the server is sending a message to the subscriber.