Add support for SendLobbyPacket and non-IPC segment types #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was not implemented.
There are a few behavioral changes as a result of this change, though
they should not affect a normal use case.
1. Deucalion now accepts a sig for SendLobbyPacket via sending a Payload
with OP `Send` and CHANNEL `0` (Lobby). Deucalion accepts a sig for
SendPacket via a Payload with OP `Send` and any CHANNEL != 0.
2. The SERVER HELLO message has been shortened like so:
`SERVER HELLO. HOOK STATUS: RECV {}. SEND {}. SEND_LOBBY {}.`
This change adds two new OPs for the protocol, one for received non-IPC segments, and one for sent non-IPC segments. The same AllowOther Option bitflag will allow for receiving this data on a subscriber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the ability to receive the Lobby channel for Send and segments that are not of type
SEGMENTTYPE_IPC.There are a few behavioral changes as a result of this change, though
they should not be breaking for standard use cases.
with OP
Sendand CHANNEL0(Lobby). Deucalion accepts a sig forSendPacket via a Payload with OP
Sendand any CHANNEL != 0.SERVER HELLO. HOOK STATUS: RECV {}. SEND {}. SEND_LOBBY {}.RecvOtherandSendOther. Subscribers can opt-into receiving them with the Option flag for allowing other packets (1 << 6).