Helping with dual range input props #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
commented
Jan 8, 2020
| @@ -1,6 +1,6 @@ | |||
| ## [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|
|||
| - Added possibility to set `aria-label` for both `min` and `max` inputs of `EuiDualRange` ([#2738](https://github.com/elastic/eui/pull/2738)) | |||
| - Added `minInputProps` and `maxInputProps` to supply more props to the inputs of `EuiDualRange` ([#2738](https://github.com/elastic/eui/pull/2738)) | |||
There was a problem hiding this comment.
Just made this more generic since it's no longer just about aria-label
| // Overridable props | ||
| aria-describedby={this.props['aria-describedby']} | ||
| aria-label={this.props['aria-label']} | ||
| {...minInputProps} |
There was a problem hiding this comment.
This is the order that I was trying to mention before. All the props below this line are mandator and therefore cannot be allowed to be overridden by ...inputProps. The only way to ensure this is that ...inputProps comes before the mandator props.
| @@ -176,56 +176,5 @@ describe('EuiDualRange', () => { | |||
|
|
|||
| expect(component).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| test('should be set only for the min input', () => { | |||
There was a problem hiding this comment.
This and the tests below were still too specific for aria-label, and really just ensuring that the input props get passed down, doesn't error out, is all that's needed here so I simplified the version above and removed these and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll comment in the diff the changes I've made.