Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small edits to github ch #26

Merged
merged 1 commit into from
Sep 11, 2024
Merged

small edits to github ch #26

merged 1 commit into from
Sep 11, 2024

Conversation

carriewright11
Copy link
Contributor

@carriewright11 carriewright11 commented Apr 28, 2023

I didn't get a chance to review this chapter earlier. This is great @cansavvy!

Do we want to talk about how the merge might require them to click the force merge button - I remember some students were confused about that in our workshop?

Maybe adding an image of merging would help.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

No spelling errors! 🎉
Comment updated at 2023-04-28 with changes from 44e046a

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

⚠️ broken urls ⚠️
There are broken urls that need to be addressed. Read this guide for more info.
Download the errors here.
Comment updated at 2023-04-28 with changes from 44e046a

@github-actions
Copy link
Contributor

The check: quiz formatting errors is currently being re-run 🏃
Comment updated at 2023-04-28 with changes from 44e046a

@carriewright11 carriewright11 requested a review from cansavvy April 28, 2023 21:58
@github-actions
Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2023-04-28 with changes from 44e046a

@cansavvy
Copy link
Contributor

I never merged this chapter, I assumed that must have been you? Anyway thanks for reviewing it now!

@cansavvy
Copy link
Contributor

Can you explain what you mean by "force merge"?

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like good changes to me!

@carriewright11
Copy link
Contributor Author

carriewright11 commented May 10, 2023

Can you explain what you mean by "force merge"?
I mean like this:
Screen Shot 2023-05-10 at 2 53 42 PM

Should we add this?

@carriewright11
Copy link
Contributor Author

I never merged this chapter, I assumed that must have been you? Anyway thanks for reviewing it now!

hmmm that's odd idk - we can check. No problem!

@cansavvy cansavvy merged commit dadd8cf into main Sep 11, 2024
@cansavvy cansavvy deleted the github_rev branch September 11, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants