Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressLoggerListener does not use right total number of tests #140

Closed
fhoeben opened this issue May 31, 2017 · 1 comment
Closed

ProgressLoggerListener does not use right total number of tests #140

fhoeben opened this issue May 31, 2017 · 1 comment

Comments

@fhoeben
Copy link
Owner

fhoeben commented May 31, 2017

The total number of tests reported by ProgressLoggerListener is not properly filled. It only lists the total number of Java test classes and not the FitNesse pages which will be included.

For instance when using the project's FixtureDebugTest, with suite: HsacAcceptanceTests.SlimTests.HttpTest the output is:

2017-05-31 21:29:47.274 testSuite Started 'nl.hsac.fitnesse.fixture.FixtureDebugTest'
2017-05-31 21:29:47.274 test Started 'HsacAcceptanceTests.SlimTests.SuiteSetUp' (0 / 1)
2017-05-31 21:29:47.300 test Finished 'HsacAcceptanceTests.SlimTests.SuiteSetUp'

2017-05-31 21:29:47.300 test Started 'HsacAcceptanceTests.SlimTests.HttpTest.HttpFileUploadTest' (1 / 1)
[Fatal Error] :1:1: Content is not allowed in prolog.
ERROR:  'Content is not allowed in prolog.'
2017-05-31 21:29:47.855 test Finished 'HsacAcceptanceTests.SlimTests.HttpTest.HttpFileUploadTest'

2017-05-31 21:29:47.856 test Started 'HsacAcceptanceTests.SlimTests.HttpTest.JsonHttpTest' (2 / 1)
2017-05-31 21:29:47.919 test Finished 'HsacAcceptanceTests.SlimTests.HttpTest.JsonHttpTest'
...

The (x / 1) is, of course, incorrect. The number 1 is calculated only considering the Java class and not the number of pages to be run. It should have been (x / 8), as the currently are 8 pages below the specified suite.

This is probably tied to the surefire/failsafe plugin update and their issue SUREFIRE-1227

@fhoeben
Copy link
Owner Author

fhoeben commented May 31, 2017

This can be fixed by explicitly ensuring the surefire-junit47 runner is used

fhoeben added a commit to fhoeben/sample-fitnesse-project that referenced this issue May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant