Http Test can now post files. Usage: post file <fileName> to <url>.

[tcnh]

Http Test can now post files. Usage: post file to .
File is expected to reside in fitnesse's files folder. Acceptance test and demo test will follow.

[fhoeben]

Cool!

I assume you will also update the documentation in the example pages.

[tcnh]

Documentation in example is updated and this method is now als called in the acceptanceTests

[fhoeben]

Here I would just mention it posts a binary file, and in the page describe its to a mocked endpoint

[tcnh]

Done

[fhoeben]

Ik zie nog falen acceptatie tests in travis:

• HsacAcceptanceTests.SlimTests.HttpTest.XmlHttpTest(nl.hsac.fitnesse.fixture.AcceptanceTest)

Time elapsed: 3.293 sec <<< FAILURE!
java.lang.AssertionError: null

• HsacAcceptanceTests.SlimTests.MockXmlServerTest(nl.hsac.fitnesse.fixture.AcceptanceTest)

  Time elapsed: 2.195 sec <<< ERROR!
  java.lang.Exception:

  3 extra request(s) received:

  1. --5zZIw8_CpYQUKncwCM23KqTo7MMPuUAOAJeAUgk
     Content-Disposition: form-data; name="test.png"; filename="test.png"
     Content-Type: application/octet-stream
     Content-Transfer-Encoding: binary
     
     
  2. --5zZIw8_CpYQUKncwCM23KqTo7MMPuUAOAJeAUgk
     Content-Disposition: form-data; name="test.png"; filename="test.png"
     Content-Type: application/octet-stream
     Content-Transfer-Encoding: binary
     
     
  3. --5zZIw8_CpYQUKncwCM23KqTo7MMPuUAOAJeAUgk
     Content-Disposition: form-data; name="test.png"; filename="test.png"
     Content-Type: application/octet-stream
     Content-Transfer-Encoding: binary
     
     

[tcnh]

test.png was niet gecommit, daarom gaat de upload test mis. Staat nu wel in de tcnh branch in mijn fork. Gaat die niet automatisch mee met deze PR?

[fhoeben]

Can we also support hyperlinks to the files section when posting?
So a reference in the wiki to the file like http://files/fileFixture/bye1.txt?

We probably need something like BrowserTest.getFilePathFromWikiUrl()...

[tcnh]

Should not be too hard to do that.
I tried the travis build as well, but fails. It looks for the fitnesse files folder in: /home/travis/build/tcnh/hsac-fitnesse-fixtures/target/fitnesse-results/files/

It would make sense that this folder doesn't exist. Is this something we should fix in the build config or in code? The AcceptanceTest does succeed when it runs locally.

[fhoeben]

The files section is moved when running tests in the CI environment. So far I mostly had files I downloaded during the test, and I wanted these to be available in the test report (and not a file in the files section available before the test started to be read by the test).

To work around this for this test we can first download a file in a test, and place that in a variable, we can then use that variable as input for the post (the fixture will see these as a wiki url).

[tcnh]

nevermind. still broken, just with a different error

[fhoeben]

Any chance the changes to this class are meant for your other branch?