Remove acceptance tests failing on GitHub #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhoeben
force-pushed
the
no_option_with_nested
branch
from
8e0998a to
5233788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently finding nested
spanelements inside aselect'soptiontags no longer works on Linux Chrome, versions 129 and higher.This failed the acceptance tests on GitHub, #691.
According to the HTML spec such elements are actually not allowed. So I removed those tests.
The functionality does still work on Mac M1, with chrome 131. For this reason I did not actually remove the functionality to attempt to find such elements from the code.