Latest apache http client version #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
fhoeben
commented
Oct 26, 2016
fhoeben
commented
- Use latest apache http client
- By default use 'standard' cookie handling
- No longer allow cookie 'version' to be set when copying browser cookies (it shouldn't be needed)
- Make http client configuration easier to change from Java code
- Allow http client usage to be modified more easily by creating subclass
…enium. Cook version attribute is outdated and should not be needed.
…n reuse. Which might not be that appropriate for tests anyway
…ict expired connections
…xt, allow subclasses to control what context should be used.
|
@ilseh does this change impact your testset (using the Fit based fixtures)? Can you test to see whether you experience any problems using the project from this branch? Thanks. |
|
@fhoeben i'm not sure when we have the opportunity to check this. Aiming at this friday for now. |
|
@ilseh Did you have a chance to look at it? |
# Conflicts: # src/main/java/nl/hsac/fitnesse/fixture/Environment.java
|
Unfortunately not. I don't know when we'll have the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.