Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update win32 test serializer to work on any win32 machine #313

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Apr 6, 2024

This Pr fixes snapshot testing on windows machines that are not CI

ideally we would want to fix this issue upstream in jest-serializer-path, but this repo seem to be no longer maintained

#327 (comment)

Copy link

changeset-bot bot commented Apr 6, 2024

⚠️ No Changeset found

Latest commit: 2d869a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 2d869a0
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/667fe252797a1e000837fbf2
😎 Deploy Preview https://deploy-preview-313--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@armano2 armano2 force-pushed the fix/correct-win32-serializer-to-work-on-any-windows branch from 99e2a3d to d88ec57 Compare April 6, 2024 12:02
@armano2
Copy link
Contributor Author

armano2 commented Jun 29, 2024

if you want we could just replace jest-serializer-path with simpler serializer

@fi3ework
Copy link
Owner

If we could makes it work with a simple, promising script, we definitely could remove jest-serializer-path.

@armano2
Copy link
Contributor Author

armano2 commented Jun 29, 2024

do you want me to update this PR, or submit it as separate one?

@fi3ework
Copy link
Owner

updating this PR is fine.

@armano2
Copy link
Contributor Author

armano2 commented Jun 29, 2024

Looks like something like this is going to work

@fi3ework
Copy link
Owner

Thank you! I'm AFK now, will take a look into the code when back later today.

Copy link
Owner

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fi3ework fi3ework merged commit 230095f into fi3ework:main Jun 29, 2024
8 checks passed
@armano2 armano2 deleted the fix/correct-win32-serializer-to-work-on-any-windows branch June 30, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants