Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port message broker to memphis #78

Merged
merged 39 commits into from
Sep 11, 2023
Merged

Port message broker to memphis #78

merged 39 commits into from
Sep 11, 2023

Conversation

Pasarus
Copy link
Member

@Pasarus Pasarus commented Jun 13, 2023

Closes #77

Description

Removes dependency on Kafka and ensures that it works with memphis

TO BE MERGED AT THE SAME TIME AS ALL THE OTHER MEMPHIS PORTS FROM RUNDETECTION, AND THE FILEWATCHER

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 93.42% and project coverage change: +1.07% 🎉

Comparison is base (97697a6) 90.24% compared to head (c471337) 91.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   90.24%   91.31%   +1.07%     
==========================================
  Files           8        9       +1     
  Lines         369      403      +34     
==========================================
+ Hits          333      368      +35     
+ Misses         36       35       -1     
Files Changed Coverage Δ
job_controller/database/db_updater.py 91.30% <ø> (ø)
job_controller/job_creator.py 100.00% <ø> (ø)
job_controller/job_watcher.py 83.67% <ø> (ø)
job_controller/main.py 92.30% <80.00%> (-2.52%) ⬇️
test/utils.py 80.00% <80.00%> (ø)
job_controller/station_consumer.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pasarus Pasarus marked this pull request as ready for review June 16, 2023 07:31
Copy link
Collaborator

@keiranjprice101 keiranjprice101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always maintain my asyncio is as crap as asyncio is, but this looks good and fine to me

@Pasarus Pasarus merged commit 9f6b0f9 into main Sep 11, 2023
6 checks passed
@Pasarus Pasarus deleted the port_to_memphis branch September 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memphis support in JobController and replace Kafka
2 participants