Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pr 1 #229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 0 additions & 166 deletions .github/workflows/on-demand-preview-build.yml

This file was deleted.

8 changes: 7 additions & 1 deletion .github/workflows/pr-review-companion.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@

name: PR review companion

on: workflow_call
on:
workflow_run:
workflows: ["PR Test"]
types:
- completed

jobs:
review:
Expand All @@ -16,6 +20,8 @@ jobs:
with:
name: build
path: build
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}

- uses: actions/checkout@v4
with:
Expand Down
20 changes: 2 additions & 18 deletions .github/workflows/pr-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,13 @@
name: PR Test

on:
# The `GITHUB_TOKEN` in workflows triggered by the `pull_request_target` event
# is granted read/write repository access.
# Please pay attention to limit the permissions of each job!
# https://docs.github.com/actions/using-jobs/assigning-permissions-to-jobs
pull_request_target:
pull_request:
branches:
- main

jobs:
tests:
if: github.repository == 'mdn/content'
# if: github.repository == 'mdn/content'
runs-on: ubuntu-latest
# Set the permissions to `read-all`, preventing the workflow from
# any accidental write access to the repository.
Expand All @@ -35,8 +31,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
ref: "${{ env.HEAD_SHA }}"

- name: Get changed files
run: |
Expand Down Expand Up @@ -143,13 +137,3 @@ jobs:

export CONTENT_ROOT=$(pwd)/files
yarn filecheck ${{ env.GIT_DIFF_FILES }}

review:
needs: tests
if: ${{ needs.tests.outputs.has_assets }}
# write permissions are required to create a comment in the corresponding PR
permissions: write-all
uses: ./.github/workflows/pr-review-companion.yml
# inherit the secrets from the parent workflow
# https://docs.github.com/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
secrets: inherit
4 changes: 3 additions & 1 deletion files/en-us/web/index.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: Web technology for developers
title: Does this work 🤷‍♂️
slug: Web
page-type: landing-page
---
Expand All @@ -8,6 +8,8 @@ page-type: landing-page
{{ListSubpages("", 1, 0, 1)}}
</section>

> **Note:** YES it does.

The open Web presents incredible opportunities for developers. To take full advantage of these technologies, you need to know how to use them. Below you'll find links to our Web technology documentation.

## Documentation for Web developers
Expand Down