-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected token ) - Failed to activate the file-icons package #753
Comments
You're running a pretty outdated version of Atom. Does upgrading not help? You shouldn't be getting syntax errors unless the extracted package files were corrupt. Could you run this command and tell me what it outputs? $ shopt -s globstar;
$ shasum ~/.atom/packages/file-icons/lib/{*.js,**/*.js} |
Ah. Didn't realize Atom was out of date. Computer was having issues with auto-update, it seems. |
No problem! I should either bump the minimum required Atom version, or investigate exactly what syntax it is that it can't handle... 🤔 |
Yeah, I'm using 1.23.3 in OSX 64x, and I'm encountering the same issue. I prefer if there is a minimum version to run it properly :D |
Well, setting a minimum version won't do any good now... 😞 If I bumped the version and cut another release, users running This issue's been opened by 30 unique visitors, so plenty more people will be complaining, I suspect. Only responsible thing to do is cut a patch release to correct it. FYI, it's the trailing commas it can't handle. Atom v1.23.3 embeds Node 7.4.0, which doesn't support trailing comma syntax introduced in Node 8+. Forgot how recent that addition was. 😕 |
Okay, fixed in |
This ensures that future package releases will stay compatible with Atom versions that support ES2017 features (notably trailing commas, which're likely to be included as a matter-of-habit). Refs: #753
Updated
file-icons
to the latest version this morning and got the error.file-icons
was the only package updated at the time.Happy to answer any questions / supply any more information that could help fix this.
It looks like the "bug" is the icons falling back to:
Atom: 1.23.3 x64
Electron: 1.6.15
OS: Mac OS X 10.13.6
Thrown From: file-icons package 2.1.23
Stack Trace
Failed to activate the file-icons package
Non-Core Packages
The text was updated successfully, but these errors were encountered: